Request for review (S): JDK-8002169: TEST_BUG: compiler/7009359/Test7009359.java sometimes times out
John Rose
john.r.rose at oracle.com
Mon Feb 11 22:38:56 PST 2013
Good testing; reviewed. — John
On Feb 11, 2013, at 3:52 PM, Krystal Mo <krystal.mo at oracle.com> wrote:
> Hi all,
>
> Could I have a review on this small change, please?
>
> Webrev: http://cr.openjdk.java.net/~kmo/8002169/webrev.00/
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8002169
>
> The test may run into timeout easier if it were ran on the client compiler (whereas the test was only meant to test the server compiler).
> To make it less prone to timeout, I did the following changes:
> 1. instead of excluding main() from compiling, specify stringmakerBUG() as dontinline in the CompileCommand, so that stringmakerBUG() will still be compiled into its own native code whereas main can run much faster.
> 2. decrease the number of test loop iterations from 1000000 to 100000
>
> Testing with JPRT,
> and tested this version of the test with JDK7b124 which didn't have the fix for 7009359 and verified the bug can still reproduce.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130211/3cc931b5/attachment.html
More information about the hotspot-compiler-dev
mailing list