RFR(XXXS): 8005772: Bad compile ID in phase events

[Vladimir Ivanov]

Nils,

I have a couple of questions.

Can you describe a scenario when compile_id == "-1" after your change?
I can't find any place in the code where "-1" is used, except the code 
you touch.

Do you intentionally leave the following code unchanged?
src/share/vm/compiler/compileBroker.cpp:
    502 void CompileTask::log_task(xmlStream* log) {
    ...
    508   if (_compile_id != 0)   log->print(" compile_id='%d'", 
_compile_id);

Best regards,
Vladimir Ivanov

On 2/13/13 12:50 PM, Nils Eliasson wrote:
> Please review this change:
>
> Webrev: http://cr.openjdk.java.net/~neliasso/8005772/webrev.01/
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005772
>
> This change makes stub-compilation report 0 as compile ID. The rationale
> is to reserve -1 for uninitialized or bad values and 0 for places where
> the compile id is unavailable. All valid compile IDs begin at 1.
>
> Thanks,
> Nils Eliasson