RFR(XXXS): 8005772: Bad compile ID in phase events

[Vladimir Ivanov]

Nils,

Thanks for the clarifications. The fix looks good to me.

Best regards,
Vladimir Ivanov

On 2/13/13 4:59 PM, Nils Eliasson wrote:
> Thanks for looking at this!
>
> On 2013-02-13 13:34, Vladimir Ivanov wrote:
>>
>> Can you describe a scenario when compile_id == "-1" after your change?
>> I can't find any place in the code where "-1" is used, except the code
>> you touch.
>
> No, I can't. I can sanitize compile_id to use uint. They are generated
> as such.
>
>>
>> Do you intentionally leave the following code unchanged?
>> src/share/vm/compiler/compileBroker.cpp:
>>    502 void CompileTask::log_task(xmlStream* log) {
>>    ...
>>    508   if (_compile_id != 0)   log->print(" compile_id='%d'",
>> _compile_id);
> No, I didn't. That code is dead. It is only reachable from
> log_task_queued() where compile_id is always > 1. I'll remove it.
>
> //Nils