RFR(M): 8008555: Debugging code in compiled method sometimes leaks memory

[Vladimir Kozlov]

Roland,

Virtual methods add vtable field to CodeString. I think we can have 
_offset in CodeString instead and use it to distinguish comments 
(_offset >= 0). It will simplify the code since you don't need 
CodeComment class.

Thanks,
Vladimir

On 2/20/13 8:24 AM, Roland Westrelin wrote:
> http://cr.openjdk.java.net/~roland/8008555/webrev.00/
>
> Debugging code such as +VerifyOops sometimes need to allocate a message string dynamically, allocates it on the C-heap and let it leak when the compiled method is reclaimed. This reuses the CodeComments machinery for these strings. It was inspired by a comment Tom made during the review of "7153771: array bound check elimination for c1":
>
>> The Assert instruction leaks memory, which I guess it ok.  Maybe there's some way it could rely on the CodeComments stuff to manage that storage?
>
> Roland.
>