RFR(M): 8007294: ReduceFieldZeroing doesn't check for dependent load and can lead to incorrect execution

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Feb 21 10:51:30 PST 2013


I thought you will change code for string instrinsics. Either verify 
both inputs or conservatively always 'fail'.

Use err_msg_res() to print base->Name():
assert(base->is_AddP(), "should be addp");

Also you can do additional simple check:

   if (other_adr == adr) {
     failed = true;
     break;
   }

Also there could be several checkcastsPP nodes, so may be use

if (base != NULL && base->uncast()->in(0) == ctl) {

Thanks,
Vladimir

On 2/21/13 1:02 AM, Roland Westrelin wrote:
> Here is a new webrev for this with your suggestions:
>
> http://cr.openjdk.java.net/~roland/8007294/webrev.01/
>
> Roland.
>


More information about the hotspot-compiler-dev mailing list