C1 FrameMap::print_frame_layout()

Mikael Vidstedt mikael.vidstedt at oracle.com
Thu Feb 21 13:23:38 PST 2013


All,

As part of cleaning up the mismatching printf arguments I ran into the 
c1_FrameMap.cpp function print_frame_layout, which was missing an 
argument. At the same time a question was raised by David Holmes [1] 
about whether or not it should use _num_monitors-1, which would mimic 
what the second part of the function does for _num_spills.

Please correct me if I'm wrong, but the print_frame_layout function is 
actually not used at all in the code, so I'm assuming it's only useful 
when debugging, and if so it's not immediately obvious which one is 
"correct". Do you think anybody has strong opinions about this? Without 
knowing more about it I would assume that it actually should be 
_num_monitors-1? Or should the whole method be removed even?

Thanks,
Mikael

[1] 
http://mail.openjdk.java.net/pipermail/hotspot-dev/2013-February/008491.html



More information about the hotspot-compiler-dev mailing list