RFR (L): 7153771: array bound check elimination for c1

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Feb 27 12:09:52 PST 2013


Roland,

In LIR_Assembler::emit_assert() you do "delete[] op->msg();". Is it 
safe? is it possible that op->msg() could be accessed after the call to 
emit_assert()? In C2 we emit instructions 2 times: one to get size and 
second is final emit. Also is it possible that op->msg() == NULL?

Changes look good to me.

Thanks,
Vladimir

On 2/27/13 3:58 AM, Roland Westrelin wrote:
>
> Here is a new webrev that includes Vladimir's feedback:
>
> http://cr.openjdk.java.net/~roland/7153771/webrev.02/
>
> Roland.
>
>


More information about the hotspot-compiler-dev mailing list