Request for reviews (S): 8005522: use fast-string instructions on x86 for zeroing
Christian Thalinger
christian.thalinger at oracle.com
Thu Jan 3 11:12:50 PST 2013
On Jan 2, 2013, at 5:22 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> On 1/2/13 4:56 PM, Christian Thalinger wrote:
>>
>> On Jan 2, 2013, at 10:28 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>
>>> Thank you, Roland
>>>
>>> I added separate mach nodes for fast stosb in .ad files to fox formats:
>>>
>>> http://cr.openjdk.java.net/~kvn/8005522/webrev.01/
>>
>> + void rep_setbyte();
>>
>> Can we name it rep_stosb? That's closer to the actual instruction.
>
> For that I also need to rename rep_set() to rep_stos():
>
> http://cr.openjdk.java.net/~kvn/8005522/webrev.02
Much better. Thanks.
-- Chris
>
> Thanks,
> Vladimir
>
>>
>> -- Chris
>>
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 1/2/13 1:39 AM, Roland Westrelin wrote:
>>>>> http://cr.openjdk.java.net/~kvn/8005522/webrev/
>>>>>
>>>>> 8005522: use fast-string instructions on x86 for zeroing
>>>>
>>>>
>>>> In x86_32.ad/x86_64.ad the rep_stos() format is no longer in sync with the code that is emitted.
>>>> Otherwise, it looks good.
>>>>
>>>> Roland.
>>>>
>>
More information about the hotspot-compiler-dev
mailing list