RFR (M): 8005419: Improve intrinsics code performance on x86 by using AVX2

[Christian Thalinger]

On Jan 7, 2013, at 4:46 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> Thanks, Christian
> 
> On 1/7/13 4:15 PM, Christian Thalinger wrote:
>> 
>> On Jan 7, 2013, at 3:26 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> 
>>> http://cr.openjdk.java.net/~kvn/8005419/webrev/
>>> 
>>> Use 256bit (AVX2) vpxor,vptest instructions in String.compareTo() and equals() intrinsics.
>>> 
>>> Added jtreg test.
>>> 
>>> Ran compiler regression tests and ctw.
>> 
>> src/cpu/x86/vm/macroAssembler_x86.cpp:
>> 
>> One thing I don't like are the upper-case names for labels.  I would prefer L_foo as we do in other code.  But I see we are already using it in near-by code.  Oh well.
> 
> I would like to avoid clean up for now.

Sure.  I was just nit-picking.

> 
>> 
>> test/compiler/8005419/Test8005419.java:
>> 
>> Is there a reason why we pass in -Xmx64m?
> 
> The test uses very little memory but by default with 64bit VM it can take Gbytes by default. It will spend more time initializing java heap than running the test.

You mean ergonomics.  Okay.

-- Chris

> 
> Thanks,
> Vladimir
> 
>> 
>> Otherwise this looks good.
>> 
>> -- Chris
>> 
>>> 
>>> Thanks,
>>> Vladimir
>>