8005818: Shark: fix OSR for non-empty incoming stack [Was: Re: RFR: Fix OSR in Shark for non-empty incoming stack]

[Remi Forax]

On 01/07/2013 11:50 PM, Christian Thalinger wrote:
> 8005818: Shark: fix OSR for non-empty incoming stack
>
> On Dec 6, 2012, at 12:30 PM, Roman Kennke <rkennke at redhat.com> wrote:
>
>> This patch disables on-stack-replacement in Shark when the incoming
>> stack-depth is > 0. (This caused a segmentation fault when running
>> SpecJVM.)
>>
>> http://cr.openjdk.java.net/~rkennke/shark-osr/webrev.00/
>>
>> I tried to figure out what to do in that case for a while, until I
>> looked at opto which simply bails out, so I decided to do the same. Is
>> there anything better that could be done without huge efforts (it seems
>> to happen very rarely after all)?

I believe it can not append with bytecode generated by javac, but may 
happen with compilers of languages that consider that that a loop is an 
expression.

>>
>> Ok to go in?
>>
>> (I have a bunch of patches coming up for Shark, I was undecided if I
>> should post them as one big or several smaller patches, and then found
>> that having several unrelated things interleaved in one patch makes it
>> really difficult to understand what it does.)
>>
>> Regards,
>> Roman
>>
>>

cheers,
Rémi