Request for review: 6896617: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() on x86

[Vladimir Kozlov]

Thank you, Ulf

Good suggestion.

Vladimir


On 1/9/13 3:08 AM, Ulf Zibis wrote:
>
> Am 09.01.2013 01:10, schrieb Vitaly Davidovich:
>> Hi Vladimir,
>>
>> encodeArray can be made static.
>>
>> Also, what's the purpose of overflow flag? Once you detect overflow can't
>> you simply return the overflow result?
>>
>> What's the key piece that allows jit to generate better code? Is it the
>> encodeArray which is nice, small, and isolated?
>>
>> Thanks
>>
>> Sent from my phone
>> On Jan 8, 2013 6:18 PM, "Vladimir Kozlov" <vladimir.kozlov at oracle.com>
>> wrote:
>>
>>> http://cr.openjdk.java.net/~**kvn/6896617_jdk/webrev<http://cr.openjdk.java.net/~kvn/6896617_jdk/webrev>
>>>
>
> I would code:
>   153             int i;
>   154             for (i = 0; i < len; i++) {
>   155                 char c = sa[sp++];
>   156                 if (c > '\u00FF')
>   157                     break;
>   158                 da[dp++] = (byte)c;
>   159             }
>
>
> -Ulf
>