RFR (S) 6518907: cleanup IA64 specific code in Hotspot
Lindenmaier, Goetz
goetz.lindenmaier at sap.com
Thu Jan 10 06:46:51 PST 2013
Hi Morris,
just remove the amd case if it's unclear to you.
I left it in just in case you find it useful. It probably belongs into a separate change, anyways.
Best regards,
Goetz.
From: Morris Meyer [mailto:morris.meyer at oracle.com]
Sent: Donnerstag, 10. Januar 2013 15:36
To: hotspot-compiler-dev at openjdk.java.net; hotspot_compiler_staff_ww_grp at oracle.com; Lindenmaier, Goetz
Subject: RFR (S) 6518907: cleanup IA64 specific code in Hotspot
Gentlefolk,
I have taken what I hope to be the final pass at https://jbs.oracle.com/bugs/browse/JDK-6518907 and incorporated the comments of Goetz Lindenmaier of SAP. Per the HotSpot workflow I have submitted this change successfully to JPRT.
Vladimir Kozlov still has a concern that has been unaddressed though, and I would like to get resolution on this point if possible.
One thing concern me is code change in os.cpp for Win64:
+ // On Windows AMD64 link() does not work as there's no back link on the stack.
+ #elif (defined(IA64) || defined(AMD64)) && defined(_WIN32)
Can someone familiar with Windows confirm if the statement in the comment and code change are correct?
Thanks to all for the previous reviews.
--mm
JBS - https://jbs.oracle.com/bugs/browse/JDK-6518907
WEBREV - http://cr.openjdk.java.net/~morris/6518907
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130110/a5417435/attachment.html
More information about the hotspot-compiler-dev
mailing list