RFR (XS): 8006109: test/java/util/AbstractSequentialList/AddAll.java fails: assert(rtype == ctype) failed: mismatched return types

[Christian Thalinger]

On Jan 11, 2013, at 4:16 PM, Vitaly Davidovich <vitalyd at gmail.com> wrote:

> Chris,
> 
> Do you need a ResourceMark for the new name() call?

You mean in ciType::print_name_on?  Wouldn't hurt.

-- Chris

> 
> Thanks
> 
> Sent from my phone
> 
> On Jan 11, 2013 5:44 PM, "Christian Thalinger" <christian.thalinger at oracle.com> wrote:
> 
> On Jan 11, 2013, at 2:14 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> > Looks good, just shift/indent err_msg_res a little to be under "(".
> 
> Done.  Thanks.  -- Chris
> 
> >
> > Thanks,
> > Vladimir
> >
> > On 1/11/13 2:05 PM, Christian Thalinger wrote:
> >> http://cr.openjdk.java.net/~twisti/8006109
> >>
> >> 8006109: test/java/util/AbstractSequentialList/AddAll.java fails: assert(rtype == ctype) failed: mismatched return types
> >> Reviewed-by:
> >>
> >> The problem are unloaded types.  Two different ciType instances of the
> >> same class type may have different loaders and protection domains
> >> depending on the accessing class.
> >>
> >> The fix is to relax the assert for unloaded types.
> >>
> >> src/share/vm/opto/doCall.cpp
> >> src/share/vm/ci/ciType.cpp
> >> src/share/vm/ci/ciType.hpp
> >>
>