Request for reviews (S) 8005821 : C2: -XX:+PrintIntrinsics is broken

[Vladimir Kozlov]

C->print_inlining_stream() is called in trace_type_profile() only with 
PrintInlining, so this code is safe.

I am pushing this fix for David.

Thanks,
Vladimir

On 1/10/13 3:07 PM, Christian Thalinger wrote:
>
> On Jan 10, 2013, at 7:58 AM, David Chase <david.r.chase at oracle.com> wrote:
>
>>
>> Webrev: http://cr.openjdk.java.net/~drchase/8005821/webrev.00/
>
> Can you please verify that +TraceTypeProfile with -PrintInlining works?
>
> void trace_type_profile(Compile* C, ciMethod *method, int depth, int bci, ciMethod *prof_method, ciKlass *prof_klass, int site_count, int receiver_count) {
>    if (TraceTypeProfile || PrintInlining NOT_PRODUCT(|| PrintOptoInlining)) {
>
> But I think it does.
>
> -- Chris
>
>>
>> Bug appeared as part of incremental inlining; a print data structure was not initialized appropriately.
>>
>> Old behavior: -XX:+PrintIntrinsics would crash.
>> New behavior: -XX:+PrintIntrinsics doesn't crash.
>>
>> Changes (all one-liners)
>> (1) modify initialization flag to match new printing behavior (fixes crash)
>> (2) modify dump_inlining method to also match new printing behavior (related behavioral glitch)
>> (3) fixed indenting of line calling dump_inlining.
>>
>> Non-change (because someone will ask):
>> Did NOT fix intending of 150-line block preceding (3).
>> Body of block is aligned with surrounding code, but { and } are undented.
>> These were (historically) added to run some destructors at the right place.
>>
>> David
>