Request for reviews (S): 8006204: please JTREGify test/compiler/7190310/Test7190310.java
Christian Thalinger
christian.thalinger at oracle.com
Wed Jan 16 10:30:09 PST 2013
Looks good. -- Chris
On Jan 16, 2013, at 8:44 AM, David Chase <david.r.chase at oracle.com> wrote:
> http://cr.openjdk.java.net/~drchase/8006204/webrev.00/
>
> pre-fix:
> Test7190310.java was a manual test because of timing issues -- failure is an infinite loop, but success may require more time than the default timeout (though usually it doesn't).
> A companion _unsafe test was already annotated correctly (no timeout needed) and already run automatically by jtreg.
>
> fix:
> Add proper jtreg annotations in the preceding comment, including an explicit timeout.
>
> post-fix:
> Both tests (Test7190310.java and Test7190310_unsafe.java) were observed to run in jtreg.
>
> Testing:
> local with jtreg and "jtreg -a" to verify that test is now automatic.
> JPRT passed.
> I tried to manually verify that JPRT ran both parts of this specific test, but could not figure out where (or if) this information was kept.
>
More information about the hotspot-compiler-dev
mailing list