Request for reviews (S): 8006204: please JTREGify test/compiler/7190310/Test7190310.java
Vladimir Kozlov
vladimir.kozlov at oracle.com
Wed Jan 16 13:54:29 PST 2013
Good. I will push it.
Thanks,
Vladimir
On 1/16/13 12:59 PM, David Chase wrote:
> Minor tweak -- the explanatory comment following the jtreg annotations was getting treated as arguments to the invocation of main. No harm today, but not not right either.
>
> New webrev:
>
> http://cr.openjdk.java.net/~drchase/8006204/webrev.03/
>
> New form of comment (webrev.00 had this all in one comment).
>
> 25 /*
> 26 * @test
> 27 * @bug 7190310
> 28 * @summary Inlining WeakReference.get(), and hoisting $referent may lead to non-terminating loops
> 29 * @run main/othervm/timeout=600 -Xbatch Test7190310
> 30 */
> 31
> 32 /*
> 33 * Note bug exhibits as infinite loop, timeout is helpful.
> 34 * It should normally finish pretty quickly, but on some especially slow machines
> 35 * it may not. The companion _unsafe test lacks a timeout, but that is okay.
> 36 */
>
>
> I checked that jtreg still behaved properly after this change.
>
> David
>
More information about the hotspot-compiler-dev
mailing list