RFR(M): pass outputStream to more opto debug routines

[Lindenmaier, Goetz]

Hi Vladimir, 

That went fast, thanks a lot! 
  Goetz.

-----Original Message-----
From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com] 
Sent: Dienstag, 22. Januar 2013 17:16
To: Lindenmaier, Goetz
Cc: hotspot-compiler-dev at openjdk.java.net
Subject: Re: RFR(M): pass outputStream to more opto debug routines

On 1/22/13 6:14 AM, Lindenmaier, Goetz wrote:
> Hi Vladimir,
>
> sorry for the late reply.  I fixed it, I like it better that way, too.
>
> But what about operators as in
>    for (i = 0; i < req(); i++) {
> should I add spaces around the '=' and '<' ?

Yes, there should be spaces as you showed.
>
> And what about function calls
>      format_helper( regalloc, st, fld_node, ":", j, &scobjs );
> Should I remove the space after the bracket?

Yes.

>
> I fixed all of them in this webrev:
> http://cr.openjdk.java.net/~goetz/webrevs/8005055/

This looks good. Thank you for cleanup. I will push it today.

Thanks,
Vladimir

> I also based it on a recent repository.
> If that's not ok, no problem, I'll remove them, again.
>
> Best regards and thanks for the review,
>    Goetz.
>
>
>
> -----Original Message-----
> From: hotspot-compiler-dev-bounces at openjdk.java.net [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
> Sent: Freitag, 14. Dezember 2012 03:11
> To: hotspot-compiler-dev at openjdk.java.net
> Subject: Re: RFR(M): pass outputStream to more opto debug routines
>
> RFE created:
>
> 8005055: pass outputStream to more opto debug routines
>
> On 12/13/12 6:03 PM, Vladimir Kozlov wrote:
>> Thank you, Goetz, for doing this.
>>
>> Changes are good. One thing I want to ask you is a small codding style
>> cleanup. We are converting all cases of "if( a )" to "if (a)" in a
>> methods we touch. And I see you have cases like that.
>>
>> Thanks,
>> Vladimir
>>
>> On 12/13/12 2:49 AM, Lindenmaier, Goetz wrote:
>>> Hi,
>>>
>>> We pass the outputStream to much more debug routines than openJDK does,
>>>
>>> as we write a lot more information to files e.g., in case of a crash.
>>>
>>> I would like to contribute the changes that allow to pass the output
>>> stream to
>>>
>>> node->dump() and everything reachable from there.
>>>
>>> This also fixes the usage of output stream in print_register_type() in
>>> oopMap.cpp and
>>>
>>> in MachNullCheckNode::format(), where a single print command still
>>> used tty.
>>>
>>> Further we initialize _node_regs_max_index so that
>>> node_regs_max_index()  == 0
>>>
>>> indicates that registers of a node can be accessed.  This is also
>>> useful in
>>>
>>> debug output.
>>>
>>> http://cr.openjdk.java.net/~goetz/webrevs/webrev-os_in_nodeDump/
>>>
>>> Best regards,
>>>
>>>     Goetz.
>>>