RFR(M): 8005439: no message about inline method if it specified by CompileCommand

[Vladimir Ivanov]

I'll sponsor the fix.

Best regards,
Vladimir Ivanov

On 1/28/13 1:05 AM, Vladimir Kozlov wrote:
> It is good.
>
> Thanks,
> Vladimir
>
> On 1/26/13 3:01 AM, Igor Ignatyev wrote:
>> Thank you for review.
>>
>> code style was cleaned up:
>> http://cr.openjdk.java.net/~vlivanov/8005439/webrev.02/
>>
>> Best regards,
>> Igor Ignatyev
>>
>> On 01/26/2013 01:55 AM, Vladimir Kozlov wrote:
>>> Code style: if you continue parameters on next line align them to first
>>> parameter:
>>>
>>> ! void InlineTree::print_inlining(ciMethod* callee_method, int
>>> caller_bci,
>>> !     const char* msg, bool success) const {
>>>
>>> !     print_inlining(callee_method, caller_bci, "failed initial checks",
>>> !         false /* !success */);
>>>
>>> and several more.
>>>
>>> Otherwise it is good. Thank you for reducing changes.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 1/25/13 1:02 PM, Igor Ignatyev wrote:
>>>> Hi Vladimir,
>>>>
>>>> Thanks a lot for feedback.
>>>> I have updated the patch according to your suggestions.
>>>>
>>>> http://cr.openjdk.java.net/~vlivanov/8005439/webrev.01/
>>>>
>>>> Best regards,
>>>> Igor Ignatyev
>>>>
>>>> On 01/23/2013 10:15 PM, Vladimir Kozlov wrote:
>>>>> Igor,
>>>>>
>>>>> I think changing C2 behavior (adding detailed success message to print
>>>>> inlining output) requires separate RFE. As I understand C2 does not
>>>>> have
>>>>> this problem, only C1.  For this bug fix I would only do your
>>>>> InlineTree::print_inlining() changes to make consistent LogCompilation
>>>>> and PrintInlining outputs.
>>>>>
>>>>> I also want to keep this fix small so we can backport it into 7
>>>>> update.
>>>>>
>>>>> Thanks,
>>>>> Vladimir
>>>>>
>>>>> On 1/23/13 12:49 AM, Igor Ignatyev wrote:
>>>>>> Hi Vladimir,
>>>>>>
>>>>>> Do you suggest to leave in the patch only changing of signature of
>>>>>> methods (try_to_inline, should_inline, should_not_inline) w/o assign
>>>>>> success message to out-parameter 'msg'?
>>>>>>
>>>>>> Best regards,
>>>>>> Igor Ignatyev
>>>>>>
>>>>>> On 01/22/2013 11:18 PM, Vladimir Kozlov wrote:
>>>>>>> Your changes in C2 are too intrusive for simple fix. You need
>>>>>>> separate
>>>>>>> RFE to print success message.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Vladimir
>>>>>>>
>>>>>>> On 1/22/13 7:05 AM, Igor Ignatyev wrote:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> Please review the fix.
>>>>>>>>
>>>>>>>> http://cr.openjdk.java.net/~vlivanov/8005439/webrev.00/
>>>>>>>>
>>>>>>>> print_inlining is not called if method specified by
>>>>>>>> '-XX:CompileCommand=inline'
>>>>>>>> so it's difficult to understand that the command works or does not
>>>>>>>> work.
>>>>>>>>
>>>>>>>> Testing: JPRT