RFR(S): JDK-8006613: adding reason to made_not_compilable

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Jan 29 12:52:52 PST 2013


On 1/29/13 12:08 PM, Igor Ignatyev wrote:
> Vladimir, thank you for review.
>
>  > Igor, what is a motivation behind all these resent log compilation
> changes?
>
> When we (VM SQE team) started writing tests for CompileCommand flag, we
> were faced with problems of recognition its actions in cout/log. Thus,
> motivation is simple: we need these changes for better testing.

Yes, it makes sense. We need better testing :)

Thanks,
Vladimir

>
> Best regards,
> Igor Ignatyev
>
> On 01/29/2013 11:19 PM, Vladimir Kozlov wrote:
>> This looks good.
>>
>> Igor, what is a motivation behind all these resent log compilation
>> changes?
>>
>> Thanks,
>> Vladimir
>>
>> On 1/28/13 10:28 PM, Igor Ignatyev wrote:
>>> Hi all,
>>>
>>> Please review the patch.
>>>
>>> patch extends signature of methods 'Method::set_not_compilable',
>>> 'Method::set_not_osr_compilable' and 'Method::print_made_not_compilable'
>>> by adding reason
>>>
>>> webrev: http://cr.openjdk.java.net/~vlivanov/8006613/webrev.00/
>>> JBS: https://jbs.oracle.com/bugs/browse/JDK-8006613


More information about the hotspot-compiler-dev mailing list