RFR (XS): Crash when running with -XX:+PrintInlining

[Roland Westrelin]

Hi Andreas,

Thank you for the bug report and suggested fix.

> - In Compile::print_inlining_skip(), the CallGenerator is not annotated at the actual _print_inlining_list array entry (type "PrintInliningBuffer") but at a copy of the entry which gets discarded.

This:
_print_inlining_list->at(_print_inlining).set_cg(cg);
only modifies a copy?

It's strange because at() is declared as:

  E& at(int i) {

so at() returns a reference and the element of the list should be modified in place, right?

There's a second at() definition:

  E const& at(int i) const {

which as I understand shouldn't be used here. What compiler are you seeing this with?

Roland.