RFR (XS): 8017578 : Hotspot compilation error with latest Studio compiler

[John Rose]

Destructors are probably overkill in adlc.  It never needs to call ::free or op delete, since it runs very briefly on a short known input.  — John

On Jul 2, 2013, at 1:08 PM, David Chase <david.r.chase at oracle.com> wrote:

> Are you sure that's a good idea?  The C++ style guides I've seen all pretty much scream at you to make destructors virtual when there's polymorphism.
> 
> On 2013-07-02, at 3:15 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
>> All destructors are empty in  Form class hierarchy. I think we should remove them all and the problem will be solved.
>> 
>> Vladimir
>> 
>> On 7/2/13 7:25 AM, David Chase wrote:
>>> bug:
>>> in src/share/vm/adlc/forms.hpp, class Form needs a virtual destructor,
>>> because it has polymorphic subtypes (that also lack virtual destructors).
>>> 
>>> fix:
>>> make the destructor virtual
>