RFR (XS): 8019625: Test compiler/8005956/PolynomialRoot.java timeouts on Solaris SPARCs

Niclas Adlertz niclas.adlertz at oracle.com
Tue Jul 9 04:06:09 PDT 2013


Thank you Pavel and Vladimir.

Kind Regards,
Niclas Adlertz


On 9 jul 2013, at 12:19, Pavel Punegov <pavel.punegov at oracle.com> wrote:

> Now changes are good.
>  
> Thanks,
> Pavel
>  
> On Monday 08 July 2013 19:42:14 Niclas Adlertz wrote:
> > Hi Pavel,
> > 
> > Thank you for your comments.
> > 
> > http://cr.openjdk.java.net/~adlertz/JDK-8019625/webrev01/
> > 
> > Kind Regards,
> > Niclas Adlertz
> > 
> > On 8 jul 2013, at 17:55, Pavel Punegov <pavel.punegov at oracle.com> wrote:
> >> Hi Niclas,
> >> 
> >> I think it would be better if there was an else part of the if statement
> >> with something like S.o.println("PASS test for non-x86"). It will show
> >> that test was skipped correctly.
> >> 
> >> And it's really good to print information about test execution and final
> >> result (pass/fail) to the output. It makes failure analysis much easier
> >> especially in cases of timeouts, environmental or infra failures.
> >> 
> >> Thanks,
> >> Pavel
> >> 
> >> On Friday 05 July 2013 14:21:19 Niclas Adlertz wrote:
> >>> Hi all,
> >>> 
> >>> Disabled the test for SPARC (the original bug 8005956 only triggers on
> >>> x86/x64) and reduced the number of iterations so that it takes less time
> >>> but still triggers.
> >>> 
> >>> WEBREV: http://cr.openjdk.java.net/~adlertz/JDK-8019625/webrev00/
> >>> JBS: https://jbs.oracle.com/bugs/browse/JDK-8019625
> >>> 
> >>> A review would be much appreciated.
> >>> 
> >>> Kind Regards,
> >>> Niclas Adlertz



More information about the hotspot-compiler-dev mailing list