RFR(XS) : 8021120 : TieredCompilation can be enabled even if TIERED is undefined

Igor Ignatyev igor.ignatyev at oracle.com
Tue Jul 23 12:23:19 PDT 2013


Thanks for review, Vladimir.

Could I have a second review for this?

Best regards,
Igor Ignatyev

On 07/23/2013 11:14 PM, Vladimir Kozlov wrote:
> Good.
>
> Thanks,
> Vladimir
>
> On 7/23/13 12:10 PM, Igor Ignatyev wrote:
>> Vladimir,
>>
>> I added a warning message.
>>
>> http://cr.openjdk.java.net/~iignatyev/8021120/webrev.01/
>>
>> Best regards,
>> Igor Ignatyev
>>
>> On 07/23/2013 07:53 PM, Vladimir Kozlov wrote:
>>> Igor,
>>>
>>> You don't need check for TieredCompilation if you don't want issue
>>> warning. Just set default to false unconditionally.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 7/23/13 5:38 AM, Igor Ignatyev wrote:
>>>> Hi all,
>>>>
>>>> Please review patch.
>>>>
>>>> Problem:
>>>> If 'COMPILER2' is defined, it will be possible to enable
>>>> 'TieredCompilation' even if 'TIERED' is undefined. But such VM
>>>> will raise error at 'compilationPolicy_init'
>>>>
>>>> Fix:
>>>> Forcibly set 'TieredCompilation' in false, if 'TIERED' is undefined.
>>>>
>>>> webrev: http://cr.openjdk.java.net/~iignatyev/8021120/webrev.00/
>>>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8021120
>>>> testing: jprt, 'java -version' on different VM (including embedded
>>>> client, server, minimal)


More information about the hotspot-compiler-dev mailing list