About bug fix of 8010278

[Kevin Walls]

Hi Yumin,

Sure no problem I'll look into it.   Looks like in ClassDump we should 
check classFilter != null before doing that initialisation in the run() 
method.

At the moment trying jtreg on test/compiler/ciReplay I get a failure in 
TestSA.sh, as it calls sun.jvm.hotspot.CLHSDB, and gives the javascript 
exceptions characteristic of 8011888.  Rebuilding with the suggested new 
sa.js I see in that bug, I'll test and let you know...

Thanks!
Kevin



On 26/07/13 02:17, Yumin Qi wrote:
> Hi, Kevin
>
> http://cr.openjdk.java.net/~kevinw/8010278/webrev.03/ 
> <http://cr.openjdk.java.net/%7Ekevinw/8010278/webrev.03/>
>   I found this fix breaks C2 replay for dumping loaded java classes:
>
>         at 
> sun.jvm.hotspot.tools.jcore.PackageNameFilter.canInclude(PackageNameFilter.java:55)
>         at 
> sun.jvm.hotspot.tools.jcore.ClassDump.dumpKlass(ClassDump.java:135)
>         at 
> sun.jvm.hotspot.tools.jcore.ClassDump.access$000(ClassDump.java:38)
>         at 
> sun.jvm.hotspot.tools.jcore.ClassDump$1.visit(ClassDump.java:106)
>         at 
> sun.jvm.hotspot.memory.Dictionary.classesDo(Dictionary.java:68)
>         at 
> sun.jvm.hotspot.memory.SystemDictionary.classesDo(SystemDictionary.java:190)
>         at sun.jvm.hotspot.tools.jcore.ClassDump.run(ClassDump.java:102)
>         at 
> sun.jvm.hotspot.DumpLoadedClasses.run(DumpLoadedClasses.java:65)
>         at 
> sun.jvm.hotspot.DumpLoadedClasses.main(DumpLoadedClasses.java:43)
>
>   The problem is with Replay, we set BootFilter and NonBootFilter for 
> ClassDump, but this changeset ignored the existing filter.
>   I filed a bug against this problem.
>
> https://jbs.oracle.com/bugs/browse/JDK-8021444
>
> Thanks
> Yumin
>
>