RFR(XS): 8015437: out-of-range SPARC assertion crash

[Christian Thalinger]

-        } else {
+        }  if (Assembler::is_simm16(pos)) {

That looks wrong.

+        } else {
+          ShouldNotReachHere();

Could you use fatal with a useful error message?

-- Chris

On Jun 4, 2013, at 8:15 AM, Morris Meyer <morris.meyer at oracle.com> wrote:

> Folks,
> 
> Could I get a review of this fix for an assembler code value out of range in the SPARC MacroAssembler?
> 
> The original code was incorrect in that it didn't check the size of the position offset.  This has been tested with JPRT.
> 
>        --mm
> 
> WEBREV - http://cr.openjdk.java.net/~morris/JDK-8015437.01
> JBS - https://jbs.oracle.com/bugs/browse/JDK-8015437