RFR (XS): 8014246: remove assert to catch access to object headers in index_oop_from_field_offset_long

[Albert Noll]

Christian, John, thanks for the reviews.
Best,
Albert

Von meinem iPhone gesendet

Am 05.06.2013 um 23:39 schrieb John Rose <john.r.rose at oracle.com>:

> On Jun 5, 2013, at 12:36 AM, Albert Noll <albert.noll at oracle.com> wrote:
> 
>> Hi,
>> 
>> thanks for reviewing this small patch. 
>> 
>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8014246
>> webrev: http://cr.openjdk.java.net/~anoll/8014246/webrev.00/
>> 
>> Problem: 
>> Graal uses Unsafe access to implement e.g. monitorenter and monitorexit in Java. The assert added with JDK-7012072 makes this impossible in debug builds.
>> 
>> Furthermore it is inconsistent since the assert is only in unsafe.cpp. If we compile and intrinsify one of these Unsafe methods the check does not apply.
> 
> It's good.  The assert has fulfilled its initial purpose of catching accidental zero offsets.  — John