RFR (L): 8005088: remove unused NativeInstruction::test methods

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Jun 6 09:47:15 PDT 2013


Albert,

Sorry but I don't think it is correct to remove this verification code.
Instead we should use our new facility to execute unit tests in VM:

execute_internal_vm_tests()

We should add new unit test method which calls all this 
NativeInstruction tests.

Vladimir

On 6/6/13 1:32 AM, Albert Noll wrote:
> Hi,
>
> thank you for reviewing this patch.
>
> webrev: http://cr.openjdk.java.net/~anoll/8005088/webrev.00/
> <http://cr.openjdk.java.net/%7Eanoll/8005088/webrev.00/>
> jbs: https://jbs.oracle.com/bugs/browse/JDK-8005088
>
> Problem: These methods were probably used during porting but were never
> called since. And only SPARC implements them.
>
> Solution: Remove unused methods
>
> Passed jprt.
>
> Thanks,
> Albert


More information about the hotspot-compiler-dev mailing list