RFR (L): 8005088: remove unused NativeInstruction::test methods

[Vladimir Kozlov]

On 6/6/13 10:09 AM, Christian Thalinger wrote:
>
> On Jun 6, 2013, at 9:47 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>
>> Albert,
>>
>> Sorry but I don't think it is correct to remove this verification code.
>> Instead we should use our new facility to execute unit tests in VM:
>>
>> execute_internal_vm_tests()
>>
>> We should add new unit test method which calls all this NativeInstruction tests.
>
> But then someone should implement the tests on the other platforms as well.

It could be done later.

Vladimir

>
> -- Chris
>
>>
>> Vladimir
>>
>> On 6/6/13 1:32 AM, Albert Noll wrote:
>>> Hi,
>>>
>>> thank you for reviewing this patch.
>>>
>>> webrev: http://cr.openjdk.java.net/~anoll/8005088/webrev.00/
>>> <http://cr.openjdk.java.net/%7Eanoll/8005088/webrev.00/>
>>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8005088
>>>
>>> Problem: These methods were probably used during porting but were never
>>> called since. And only SPARC implements them.
>>>
>>> Solution: Remove unused methods
>>>
>>> Passed jprt.
>>>
>>> Thanks,
>>> Albert
>