RFR (S) : 8014959 : assert(Compile::current()->live_nodes() < (uint)MaxNodeLimit) failed: Live Node limit exceeded limit

[Vladimir Kozlov]

On 6/11/13 10:35 AM, David Chase wrote:
>
> On 2013-06-10, at 12:42 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>
>> David,
>>
>> In what place you hit "out of nodes" failure if you don't increase NodeLimitFudgeFactor?
>
> I don't recall exactly where -- but there was one different, in one of my hundred-iteration test runs.
> I didn't see much harm in doubling the padding, given the difficulty of reproducing the error, and not knowing how many more I might find if I just upped the test count to 1000, or perhaps 10000.

Okay.

>> I think we can still hit "out of nodes" during insert_copies() because 6000 may be not enough for huge method with a lot of blocks. Could you do the check on each iteration in blocks loop?:
>
> I did that, and retested.
>
> http://cr.openjdk.java.net/~drchase/8014959/webrev.01/

Why you kept the check before insert_copies() call? The check inside 
insert_copies() should be enough since it is done on loop entry. Note, 
"Fix block's liveout data" loop does not add new nodes.

Vladimir

>
> David
>