RFR(XS) 8009156 [parfait] Null pointer deference in hotspot/src/share/vm/services/memoryService.cpp

Christian Thalinger christian.thalinger at oracle.com
Thu Mar 14 14:04:11 PDT 2013


Maybe instead of:

+  assert(gen != NULL, "No generation for memory pool");
+  if (gen == NULL) {
+    ShouldNotReachHere();
+    return;
+  }

do this:

+  if (gen == NULL) {
+    fatal("No generation for memory pool");
+    return;
+  }

-- Chris

On Mar 14, 2013, at 8:32 AM, Morris Meyer <morris.meyer at oracle.com> wrote:

> Folks,
> 
> Could I get a quick review for these fixes for parfait null pointer issues? This has been through JPRT.
> 
> Thanks in advance,
> 
>        --morris meyer
> 
> WEBREV - http://cr.openjdk.java.net/~morris/8009156.01
> JIRA - https://jbs.oracle.com/bugs/browse/JDK-8009156
> 



More information about the hotspot-compiler-dev mailing list