RFR(XXS) 8010144 [parfait] Null pointer deference in hotspot/src/os_cpu/linux_x86/vm/os_linux_x86.cpp

[Morris Meyer]

Folks,

Could I get a quick review for this duplicate change of the approved fix 
for 8008560 applied to its sibling file os_linux_x86.cpp?

Thanks to Daniel for pointing this out.

         --morris

WEBREV - http://cr.openjdk.java.net/~morris/8010144.01
JIRA - https://jbs.oracle.com/bugs/browse/JDK-8010144


On 3/15/13 9:08 AM, Daniel D. Daugherty wrote:
> Morris,
>
> It looks like the same fix that you applied to the BSD code is
> needed in the Linux code (which is not a surprise):
>
> src/os_cpu/linux_x86/vm/os_linux_x86.cpp:
>
>    338        } else if (sig == SIGBUS /* && info->si_code == 
> BUS_OBJERR */) {
>    339          // BugId 4454115: A read from a MappedByteBuffer can 
> fault
>    340          // here if the underlying file has been truncated.
>    341          // Do not crash the VM in such a case.
>    342          CodeBlob* cb = CodeCache::find_blob_unsafe(pc);
>    343          nmethod* nm = cb->is_nmethod() ? (nmethod*)cb : NULL;
>    344          if (nm != NULL && nm->has_unsafe_access()) {
>    345            stub = StubRoutines::handler_for_unsafe_access();
>    346          }
>    347        }
>
> The BSD port was derived from the Linux code base so this is not
> a surprise. Is there a separate Parfait bug for the same Linux bug?
>
> Dan
>
>
>
> On 3/15/13 5:23 AM, morris.meyer at oracle.com wrote:
>> Changeset: 71f13276159d
>> Author:    morris
>> Date:      2013-03-14 07:44 -0700
>> URL: 
>> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/71f13276159d
>>
>> 8008560: [parfait] Null pointer deference in 
>> hotspot/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp
>> Summary: add null pointer check in signal handler
>> Reviewed-by: kvn
>>
>> ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp
>>