RFR(XS) 8009156 [parfait] Null pointer deference in hotspot/src/share/vm/services/memoryService.cpp

[Vladimir Kozlov]

Good.

Vladimir

On 3/15/13 9:20 AM, Morris Meyer wrote:
> Thanks for the review Christian and Vladimir.
>
> Here is the updated webrev - checked with parfait but not with JPRT.
>
>          --mm
>
> WEBREV - http://cr.openjdk.java.net/~morris/8009156.02
>
> On 3/14/13 5:27 PM, Vladimir Kozlov wrote:
>> Agree.
>>
>> Vladimir
>>
>> On 3/14/13 2:04 PM, Christian Thalinger wrote:
>>> Maybe instead of:
>>>
>>> +  assert(gen != NULL, "No generation for memory pool");
>>> +  if (gen == NULL) {
>>> +    ShouldNotReachHere();
>>> +    return;
>>> +  }
>>>
>>> do this:
>>>
>>> +  if (gen == NULL) {
>>> +    fatal("No generation for memory pool");
>>> +    return;
>>> +  }
>>>
>>> -- Chris
>>>
>>> On Mar 14, 2013, at 8:32 AM, Morris Meyer <morris.meyer at oracle.com>
>>> wrote:
>>>
>>>> Folks,
>>>>
>>>> Could I get a quick review for these fixes for parfait null pointer
>>>> issues? This has been through JPRT.
>>>>
>>>> Thanks in advance,
>>>>
>>>>         --morris meyer
>>>>
>>>> WEBREV - http://cr.openjdk.java.net/~morris/8009156.01
>>>> JIRA - https://jbs.oracle.com/bugs/browse/JDK-8009156
>>>>
>>>
>