RFR(S) 8010121: Remove definition of ShouldNotReachHere2(msg)

[Niclas Adlertz]

Hi all.

Problem:
We have methods fatal(msg), ShouldNotReachHere() and ShouldNotReachHere2(msg). The ShouldNotReachHere2(msg) is identical to fatal(msg). There is no need for two identical methods.

Solution:
Remove the definition of ShouldNotReachHere2(msg) and replace its uses with fatal(msg).

A review would be much appreciated. 
Thank you.

Regards,
Niclas Adlertz

---------------------

WEBREV: http://cr.openjdk.java.net/~neliasso/8010121/webrev.01/
BUG: https://jbs.oracle.com/bugs/browse/JDK-8010121, http://bugs.sun.com/view_bug.do?bug_id=8010121