RFR(S) 8010121: Remove definition of ShouldNotReachHere2(msg)

Niclas Adlertz niclas.adlertz at oracle.com
Tue Mar 19 02:44:48 PDT 2013


Thank you Vladimir, Christian, Rickard and Stefan.

Regards,
Niclas Adlertz


On 18 mar 2013, at 17:45, Vladimir Kozlov wrote:

> Looks good.
> 
> Thanks,
> Vladimir
> 
> On 3/18/13 2:13 AM, Niclas Adlertz wrote:
>> Hi all.
>> 
>> Problem:
>> We have methods fatal(msg), ShouldNotReachHere() and ShouldNotReachHere2(msg). The ShouldNotReachHere2(msg) is identical to fatal(msg). There is no need for two identical methods.
>> 
>> Solution:
>> Remove the definition of ShouldNotReachHere2(msg) and replace its uses with fatal(msg).
>> 
>> A review would be much appreciated.
>> Thank you.
>> 
>> Regards,
>> Niclas Adlertz
>> 
>> ---------------------
>> 
>> WEBREV: http://cr.openjdk.java.net/~neliasso/8010121/webrev.01/
>> BUG: https://jbs.oracle.com/bugs/browse/JDK-8010121, http://bugs.sun.com/view_bug.do?bug_id=8010121
>> 



More information about the hotspot-compiler-dev mailing list