RFR (XS): 8010222: 8007439 disabled inlining of cold accessor methods

[Christian Thalinger]

On Mar 18, 2013, at 9:14 PM, John Rose <john.r.rose at oracle.com> wrote:

> On Mar 18, 2013, at 3:40 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
>> The main problem is there are some people who write code like:
>> 
>>   if (foo)
>>     return false;
>> 
>> without curly braces.  You know who you are ;-)
> 
> That would be me for one.  And "main problem" is overstating it.
> 
> The main problem is breaking code.  Debatable practices which make breaks more or less likely are not the main problem!

True.  I was overstating.

I know this doesn't solve the problem of breaking code but how about having an auto-formatting tool on Mercurial commits?  Or when generating webrevs?  Then reviewers could spot the breakage.

-- Chris

> 
> — John

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130319/012164f5/attachment.html