RFR(XS) 8009181: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopTransform.cpp

[Vladimir Kozlov]

Missed renaming:

-  ok.set(head->loopexit()->_idx);
+  ok.set(head_exit->_idx);

otherwise good.

Vladimir

On 3/19/13 2:23 PM, Morris Meyer wrote:
> Thanks again for your review Vladimir. Here's the updated webrev.
>
>          --mm
>
> WEBREV - http://cr.openjdk.java.net/~morris/8009181.02
>
> On 3/19/13 4:34 PM, Vladimir Kozlov wrote:
>> You don't need next guarantee because as_CountedLoop() is only cast:
>>
>>    CountedLoopNode *main_head = loop->_head->as_CountedLoop();
>> +  guarantee(main_head != NULL, "no main head loop node");
>>
>> and change message in next guarantee():
>>
>>    CountedLoopEndNode *main_end = main_head->loopexit();
>> +  guarantee(main_end != NULL, "no main end loop node");
>>
>> use loop_exit name instead of head_exit:
>>
>> +  CountedLoopEndNode* head_exit = head->loopexit();
>>
>> Vladimir
>>
>> On 3/19/13 12:34 PM, Morris Meyer wrote:
>>> Folks,
>>>
>>> Could I get a review for this parfait issue?  This change has been
>>> through JPRT-hotspotwest.
>>>
>>> Thanks in advance,
>>>
>>>          --morris
>>>
>>> WEBREV - http://cr.openjdk.java.net/~morris/8009181.01
>>> BUG - https://jbs.oracle.com/bugs/browse/JDK-8009181
>>>
>>>
>