RFR(S) 8010281: Remove code that never execute in opto/ifg.cpp
Vladimir Kozlov
vladimir.kozlov at oracle.com
Mon Mar 25 09:00:42 PDT 2013
Looks good.
Thanks,
Vladimir
On 3/25/13 2:59 AM, Niclas Adlertz wrote:
> Thank you Vladimir, the new empty lines are now removed.
>
> http://cr.openjdk.java.net/~neliasso/8010281/webrev03
>
> Regards,
> Niclas Adlertz
>
>
> On 22 mar 2013, at 17:16, Vladimir Kozlov wrote:
>
>> Please, remove new empty lines.
>>
>> Vladimir
>>
>> On 3/20/13 1:02 AM, Niclas Adlertz wrote:
>>> Hi all.
>>>
>>> Problem:
>>> In the C2 register allocator, the define EXACT_PRESSURE is set to decide how we estimate the block pressure. There are currently two different ways on how to estimate this. However, EXACT_PRESSURE is always set to 1. This means that the code for the second choice on how to estimate block pressure is never executed, and therefore not needed.
>>>
>>> Solution:
>>> Remove the define EXACT_PRESSURE and the code that is never executed; executing only the code that now executes within the ifdefs of EXACT_PRESSURE.
>>>
>>> A review would be much appreciated.
>>> Thank you.
>>>
>>> Regards,
>>> Niclas Adlertz
>>>
>>> ---------------------
>>>
>>> WEBREV: http://cr.openjdk.java.net/~neliasso/8010281/webrev00/
>>> BUG: https://jbs.oracle.com/bugs/browse/JDK-8010281, http://bugs.sun.com/view_bug.do?bug_id= 8010281
>>>
>
More information about the hotspot-compiler-dev
mailing list