RFR (XS): 8010460: Interpreter on some platforms loads ConstMethod::_max_stack and misses extra stack slots for JSR 292

Roland Westrelin roland.westrelin at oracle.com
Mon Mar 25 09:09:37 PDT 2013


Hi Christian,

Thanks for taking a look at this.

> cpu/sparc/vm/templateInterpreter_sparc.cpp
> 502:    //6815692//Method::extra_stack_words() +       // extra push slots for MH adapters
> 1553:                   //6815692//+ Method::extra_stack_words()
> 
> Especially the second one in templateInterpreter_sparc.cpp.

The second one is misleading because size_activation_helper() is passed Method::max_stack() which accounted for the extra stack slot for the appendix before my change (and still does).

Other commented Method::extra_stack_words() are not needed either so I'll remove them.

Roland.


More information about the hotspot-compiler-dev mailing list