RFR (XS): 8010460: Interpreter on some platforms loads ConstMethod::_max_stack and misses extra stack slots for JSR 292
Roland Westrelin
roland.westrelin at oracle.com
Fri Mar 29 11:22:36 PDT 2013
Thanks for reviewing this.
> Good. It's time to get rid of the //6815692// stuff. The extra_stack variables (always zero now) can go away too.
I'm not sure what to do with this:
guarantee(!EnableInvokeDynamic, "no support yet for java.lang.invoke.MethodHandle"); //6815692
//6815692//if (EnableInvokeDynamic)
//6815692// __ inc(O3, Method::extra_stack_entries());
in cppInterpreter_sparc.cpp
> I think extra_stack_words can be deleted, and extra_stack_entries can be made private to Method.
>
> This line of code is redundant in src/cpu/x86/vm/templateInterpreter_x86_{32,64}.cpp:
> const int extra_stack = Method::extra_stack_entries();
I applied Christian's suggestions and yours and found a reference to Method::extra_stack_entries() in c2 that I assume can be removed. Here is a new webrev:
http://cr.openjdk.java.net/~roland/8010460/webrev.01/
Roland.
More information about the hotspot-compiler-dev
mailing list