RFR (XS): JDK-8013496: Code cache management command line options work only in special order. Another order of arguments does not deliver the second parameter to the jvm.

[Albert Noll]

Hi all,
I did the changes as proposed:
1) the added check in Arguments::check_stack_pages() checks if 
ReservedCodeCacheSize < InitialCodeCacheSize and
     reports an error if true
2) the range check of ReservedCodeCacheSize argument only checks if the 
argument is >0k.

webrev: http://cr.openjdk.java.net/~adlertz/JDK-8013496/webrev01/

Many thanks for the discussions and the reviews,
Albert

On 05/04/2013 08:19 PM, Albert Noll wrote:
> Sure, I will take care of it on Monday.
>
> Albert
>
> On 05/04/2013 04:24 PM, Pavel Punegov wrote:
>>
>> Albert,
>>
>> Could you please write a regression test or file an RFE for new test?
>>
>> AFAIK CodeCache management is one of the JDK8 features, so it should 
>> have a regression test for any product bug found. Or if there are no 
>> test, appropriate tag should be added according to this:
>>
>> http://wiki.se.oracle.com/display/JPG/Java+SE+Bug+Tagging+Conventions
>>
>> On Пт, 03 мая 2013 14:54:56 Albert Noll wrote:
>>
>> > Hi,
>>
>> >
>>
>> > please review the patch.
>>
>> >
>>
>> > Many thanks in advance,
>>
>> > Albert
>>
>> >
>>
>> > jbs: https://jbs.oracle.com/bugs/browse/JDK-8013496
>>
>> > webrev: http://cr.openjdk.java.net/~adlertz/JDK-8013496/webrev00/
>>
>> >
>>
>> > Problem:
>>
>> > The order in which the arguments "-XX:ReservedCodeCacheSize=1m" and
>>
>> > "-XX:InitialCodeCacheSize=500k"
>>
>> > are given to hotspot mattered. In particular, the above order resulted
>>
>> > in an error:
>>
>> >
>>
>> > Invalid maximum code cache size: -XX:ReservedCodeCacheSize=1m. 
>> Should be
>>
>> > greater than InitialCodeCacheSize=2496K
>>
>> > Error: Could not create the Java Virtual Machine.
>>
>> > Error: A fatal exception has occurred. Program will exit.
>>
>> >
>>
>> > Fix: Moved the check: ReservedCodeCacheSize >= InitialCodeCacheSize to
>>
>> > Arguments::check_vm_args_consistency()
>>
>> > (as suggested in the comment).
>>
>> >
>>
>> > Currently, the minimum ReservedCodeCacheSize is 1K. Any thoughts on 
>> that?
>>
>> -- 
>>
>> Thanks,
>>
>> Pavel Punegov
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130506/5a5d5249/attachment.html