RFR (XS): 8006199: [parfait] Possible null pointer dereference at hotspot/src/share/vm/opto/loopopts.cpp

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon May 6 10:22:59 PDT 2013


Albert,

Changes are incorrect. as_Proj() is simple cast so it can't return NULL:

   type##Node *as_##type() const {                            \
     assert(is_##type(), "invalid node class");               \
     return (type##Node*)this;                                \
   }                                                          \

Vladimir

On 5/6/13 6:44 AM, Albert Noll wrote:
> Hi all,
>
> please review this patch.
>
> Many thanks in advance,
> Albert
>
> jbs: https://jbs.oracle.com/bugs/browse/JDK-8006199
> webrev: http://cr.openjdk.java.net/~adlertz/JDK-8006199/webrev00/
>
> Most reported issues are fixed in JDK-8008811, except for one issue.
> This patch adds a guarantee() to check the potential null pointer.
>
> Test:
> jprt -testset compiler


More information about the hotspot-compiler-dev mailing list