RFR (XXS): 8012312: hsdis fails to compile with binutils-2.23.2

[Volker Simonis]

Sounds good!

Thanks for the clarification,
Volker



On Thu, May 16, 2013 at 1:46 PM, Albert Noll <albert.noll at oracle.com> wrote:

>  Hi Volker,
>
> thanks for pointing this out.
>
> On 16.05.2013 10:46, Volker Simonis wrote:
>
>  Hi Albert,
>
> where does <config.h> comes from and what is it good for?
>
> <config.h> is generated by the configure script(s) of binutils.
>
>  Will this still work on other platforms and with other versions of
> binutils or do we need to include it conditionally?
>
> I built hsdis on Linux and Solaris 11 with <config.h> included for
> different versions.
> The oldest version was binutils 2.17. Worked fine.
>
> Best,
> Albert
>
>
>  Thanks,
>  Volker
>
> On Thu, May 16, 2013 at 10:28 AM, Albert Noll <albert.noll at oracle.com>wrote:
>
>> Hi all,
>>
>> please review this patch.
>>
>> Many thanks in advance,
>> Albert
>>
>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8012312
>> webrev: http://cr.openjdk.java.net/~anoll/8012312/webrev.00/
>>
>> Problem: hsdis fails to compile with binutils 2.23.2
>> Solution: Added <config.h>
>>
>> With this change, hsdis compiles on my Linux 64-bit system.
>>
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130516/dcc9edd9/attachment.html