RFR (S) : 8014362 : Need to expose some processor features via Unsafe interface

[David Chase]

On 2013-05-16, at 6:16 PM, John Rose <john.r.rose at oracle.com> wrote:

> On May 16, 2013, at 2:56 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
>> Hmm.  Tao spent a lot of time to move all processor specific flags into the respective globals_<arch>.hpp file.  I don't think we should undo this.
> 
> I agree.  That opens the question of how to manage the PUTPROP call in shared code (jvm.cpp).
> 
> David, as a least-bad solution, I suggest protecting the x86-specific names in jvm.cpp with X86_ONLY:
> 
> +  X86_ONLY(PUTPROP(props, "sun.zip.clmulSupported", UseAVX && UseCLMUL ? "true" : "false"));
> 
> or:
> 
> +  PUTPROP(props, "sun.zip.clmulSupported", X86_ONLY(UseAVX && UseCLMUL ||) false ? "true" : "false"));
> 
> or:
> 
> +  PUTPROP(props, "sun.zip.clmulSupported", X86_ONLY(UseAVX && UseCLMUL ? "true" :) "false"));
> 
> — 

That seems entirely reasonable, and allows me to move CLMUL into the x86 file.  I wasn't sure what our attitude was towards #ifdefs in that code.  I'll try to have a new webrev up soon.

David