RFR (XS): JDK-8013496: Code cache management command line options work only in special order. Another order of arguments does not deliver the second parameter to the jvm.

[Christian Thalinger]

On May 23, 2013, at 4:59 AM, Albert Noll <albert.noll at oracle.com> wrote:

> Hi,
> 
> Vladimir, thanks for the hint. Here is the new version:
> http://cr.openjdk.java.net/~anoll/8013496/webrev.04/

Yes, looks good.  -- Chris

> 
> Best,
> Albert
> 
> On 23.05.2013 00:17, Vladimir Kozlov wrote:
>> "if diff 1.out 2.out >$NULL" may not work on all platforms. 
>> Could you do it similar to test/compiler/5091921/Test6890943.sh ? 
>> 
>> Thanks, 
>> Vladimir 
>> 
>> On 5/22/13 2:21 PM, Albert Noll wrote: 
>>> Hi, 
>>> 
>>> I added a test that checks that the patch works. 
>>> 
>>> Many thanks in advance for reviewing! 
>>> 
>>> webrev: https://jbs.oracle.com/bugs/browse/JDK-8013496 
>>> jbs: http://cr.openjdk.java.net/~anoll/8013496/webrev.03/ 
>>> <http://cr.openjdk.java.net/%7Eanoll/8013496/webrev.03/> 
>>> 
>>> Best, 
>>> Albert 
>>> 
>>> On 07.05.2013 19:25, Christian Thalinger wrote: 
>>>> Thanks.  Looks good.  -- Chris 
>>>> 
>>>> On May 7, 2013, at 1:28 AM, Albert Noll <albert.noll at oracle.com 
>>>> <mailto:albert.noll at oracle.com>> wrote: 
>>>> 
>>>>> Hi Christian, 
>>>>> thanks for reviewing. I made the proposed changes. 
>>>>> Here is the updated webrev. 
>>>>> 
>>>>> http://cr.openjdk.java.net/~adlertz/JDK-8013496/webrev02/ 
>>>>> 
>>>>> Albert 
>>>>> 
>>>>> On 05/06/2013 09:25 PM, Christian Thalinger wrote: 
>>>>>> 
>>>>>> On May 6, 2013, at 1:18 AM, Albert Noll <albert.noll at oracle.com 
>>>>>> <mailto:albert.noll at oracle.com>> wrote: 
>>>>>> 
>>>>>>> Hi all, 
>>>>>>> I did the changes as proposed: 
>>>>>>> 1) the added check in Arguments::check_stack_pages() checks if 
>>>>>>> ReservedCodeCacheSize < InitialCodeCacheSize and 
>>>>>>>     reports an error if true 
>>>>>>> 2) the range check of ReservedCodeCacheSize argument only checks if 
>>>>>>> the argument is >0k. 
>>>>>>> 
>>>>>>> webrev: http://cr.openjdk.java.net/~adlertz/JDK-8013496/webrev01/ 
>>>>>> 
>>>>>> +  if (ReservedCodeCacheSize < InitialCodeCacheSize) { 
>>>>>> +          jio_fprintf(defaultStream::error_stream(), 
>>>>>> +        "Invalid ReservedCodeCacheSize: %dK. Should be greater than InitialCodeCacheSize=%dK\n", 
>>>>>> Indenting is odd. 
>>>>>> +                    "Invalid maximum code cache size: %s.\n",option->optionString); 
>>>>>> And a space after "," would be nice. 
>>>>>> 
>>>>>> -- Chris 
>>>>>> 
>>>>>>> 
>>>>>>> Many thanks for the discussions and the reviews, 
>>>>>>> Albert 
>>>>>>> 
>>>>>>> On 05/04/2013 08:19 PM, Albert Noll wrote: 
>>>>>>>> Sure, I will take care of it on Monday. 
>>>>>>>> 
>>>>>>>> Albert 
>>>>>>>> 
>>>>>>>> On 05/04/2013 04:24 PM, Pavel Punegov wrote: 
>>>>>>>>> Albert, 
>>>>>>>>> 
>>>>>>>>> Could you please write a regression test or file an RFE for new test? 
>>>>>>>>> AFAIK CodeCache management is one of the JDK8 features, so it 
>>>>>>>>> should have a regression test for any product bug found. Or if 
>>>>>>>>> there are no test, appropriate tag should be added according to this: 
>>>>>>>>> http://wiki.se.oracle.com/display/JPG/Java+SE+Bug+Tagging+Conventions 
>>>>>>>>> 
>>>>>>>>> On Пт, 03 мая 2013 14:54:56 Albert Noll wrote: 
>>>>>>>>> > Hi, 
>>>>>>>>> > 
>>>>>>>>> > please review the patch. 
>>>>>>>>> > 
>>>>>>>>> > Many thanks in advance, 
>>>>>>>>> > Albert 
>>>>>>>>> > 
>>>>>>>>> > jbs: https://jbs.oracle.com/bugs/browse/JDK-8013496 
>>>>>>>>> > webrev: http://cr.openjdk.java.net/~adlertz/JDK-8013496/webrev00/ 
>>>>>>>>> > 
>>>>>>>>> > Problem: 
>>>>>>>>> > The order in which the arguments "-XX:ReservedCodeCacheSize=1m" and 
>>>>>>>>> > "-XX:InitialCodeCacheSize=500k" 
>>>>>>>>> > are given to hotspot mattered. In particular, the above order 
>>>>>>>>> resulted 
>>>>>>>>> > in an error: 
>>>>>>>>> > 
>>>>>>>>> > Invalid maximum code cache size: -XX:ReservedCodeCacheSize=1m. 
>>>>>>>>> Should be 
>>>>>>>>> > greater than InitialCodeCacheSize=2496K 
>>>>>>>>> > Error: Could not create the Java Virtual Machine. 
>>>>>>>>> > Error: A fatal exception has occurred. Program will exit. 
>>>>>>>>> > 
>>>>>>>>> > Fix: Moved the check: ReservedCodeCacheSize >= 
>>>>>>>>> InitialCodeCacheSize to 
>>>>>>>>> > Arguments::check_vm_args_consistency() 
>>>>>>>>> > (as suggested in the comment). 
>>>>>>>>> > 
>>>>>>>>> > Currently, the minimum ReservedCodeCacheSize is 1K. Any 
>>>>>>>>> thoughts on that? 
>>>>>>>>> -- 
>>>>>>>>> Thanks, 
>>>>>>>>> Pavel Punegov 
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130523/3e3e33f7/attachment-0001.html