RFR(S): 8013329: [parfait] File leak in hotspot/src/share/vm/compiler/compileBroker.cpp

Albert Noll albert.noll at oracle.com
Fri May 24 06:28:13 PDT 2013


Hi,

thanks for reviewing this.

Best,
Albert

jbs: https://jbs.oracle.com/bugs/browse/JDK-8013329
webrev: http://cr.openjdk.java.net/~anoll/8013329/webrev.00/ 
<http://cr.openjdk.java.net/%7Eanoll/8013329/webrev.00/>

Problem:
The file opened in compileBroker.cpp (line 1659) is passed to the
CompileLog constructor and never closed. In addition, the memory allocated
to '_file' in line 1661 in compileBroker.cpp is never freed.

Solution:
Added calling the destructor of CompileLog (which closes the file) in
CompileLog::finish_log_on_error(). Furthermore, added freeing memory
of '_file' in destructor of CompileLog.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130524/559ef508/attachment.html 


More information about the hotspot-compiler-dev mailing list