RFR(S): 8013329: [parfait] File leak in hotspot/src/share/vm/compiler/compileBroker.cpp

[Albert Noll]

Hi Roland,

thanks for the review!

On 24.05.2013 16:43, Roland Westrelin wrote:
> Hi Albert,
>
>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8013329
>> webrev: http://cr.openjdk.java.net/~anoll/8013329/webrev.00/
> FREE_C_HEAP_ARRAY is for arrays allocated with NEW_C_HEAP_ARRAY. You should use delete here, I think (even though FREE_C_HEAP_ARRAY and delete end up doing the same).
The char array is allocated with NEW_HEAP_ARRAY in compileBroker.cpp. In 
the new version, I moved
the allocation of the array into the constructor of CompileLog. I think 
that this makes the code better readable. Do you agree?
> In CompileLog::finish_log_on_error, you delete log but use it afterwards log = log->_next.
Ouch :-( Thanks for this one. I think the current version should be fine.

> Have you tried running with -XX:+LogCompilation?
Yes, I tested the previous and the current version using 
-XX:+LogCompilation; also with -XX:LogFile=..
Seems to work ok.

> Roland.
>
Here is the updated version:
http://cr.openjdk.java.net/~anoll/8013329/webrev.01/ 
<http://cr.openjdk.java.net/%7Eanoll/8013329/webrev.01/>
Thanks again for looking!

Best,
Albert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130527/bf681c37/attachment.html