RFR (S): 8015266: fix some -Wsign-compare warnings in adlc

[Christian Thalinger]

Thank you, Vladimir.  -- Chris

On May 29, 2013, at 12:34 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> Good.
> 
> Thanks,
> Vladimir
> 
> On 5/29/13 12:03 PM, Christian Thalinger wrote:
>> 
>> On May 29, 2013, at 11:27 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> 
>>> On 5/23/13 11:28 AM, Christian Thalinger wrote:
>>>> http://javaweb.us.oracle.com/~cthaling/webrev/8015266/webrev/
>>>> 
>>>> 8015266: fix some -Wsign-compare warnings in adlc
>>>> Reviewed-by:
>>>> 
>>>> Some warnings I've found while hacking on the build system.
>>>> 
>>> 
>>> In general it is good. could you fix code style (spaces in if() and for()) around codes you fixed?
>> 
>> Sure.  I did some cleanups in the methods I've touched:
>> 
>> http://cr.openjdk.java.net/~twisti/8015266/webrev/
>> 
>> Maybe we could use one of the formatting tools on ADLC as a precedent?
>> 
>>> 
>>>> src/share/vm/adlc/archDesc.cpp
>>>> src/share/vm/adlc/dict2.cpp
>>> 
>>> Align comment:
>>> 
>>> // Characters are always odd!
>> 
>> Done.
>> 
>> -- Chris
>> 
>>> 
>>>> src/share/vm/adlc/formssel.cpp
>>>> src/share/vm/adlc/formssel.hpp
>>>> src/share/vm/adlc/output_c.cpp
>>>> 
>>> 
>>> thanks,
>>> Vladimir
>>