RFR(XS): 8028109: compiler/codecache/CheckReservedInitialCodeCacheSizeArgOrder.java crashes in RT_Baseline

Albert Noll albert.noll at oracle.com
Tue Nov 19 00:37:27 PST 2013


Hi all,

could I get reviews for this small patch?

bug: https://bugs.openjdk.java.net/browse/JDK-8028109
webrev: http://cr.openjdk.java.net/~anoll/8028109/webrev.00/

Problem: 'byte_map_base' in 'cardTableModRefBS.cpp' can have a value 
that points into the code cache.
                 The x86 stub generator uses 'ExternalAddress' for 
byte_map_base, which results in creating
                 a relocation entry for 'byte_map_address'. If 
byte_map_base - by accident - points into the
                 code section of, e.g., a buffer blob, the assert in 
relocInfo.cpp (line 831 fails)

Solution: Change 'ExternalAddress' to 'AddressLiteral' that generates no 
relocation information for
                byte_map_base. Other platforms also AddressLiteral 
without relocation information.

Testing: failing test, jprt x86

Many thanks to Roland who helped me in understanding this bug!

Best,
Albert


More information about the hotspot-compiler-dev mailing list