RFR(XS): 8028109: compiler/codecache/CheckReservedInitialCodeCacheSizeArgOrder.java crashes in RT_Baseline

[Albert Noll]

Hi Roland,

thanks for pointing this out. Here is a patch that executes the assert 
only if
the address we are checking is not byte_map_base. This might not be the most
elegant solution, but at least it seems to work.

Here is the new webrev:
http://cr.openjdk.java.net/~anoll/8028109/webrev.01/

Best,
Albert


On 11/19/2013 10:00 AM, Roland Westrelin wrote:
>> Solution: Change 'ExternalAddress' to 'AddressLiteral' that generates no relocation information for
>>                byte_map_base. Other platforms also AddressLiteral without relocation information.
> As mentioned in the thread here:
> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2011-April/005151.html
> in this message:
> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2011-April/005161.html
>
> not using ExternalAddress disables rip relative addressing.
> This said, I’m not sure what a clean fix for this would be.
>
> Roland.