RFR(XS): 8028997: mathexact intrinsics are unstabl

Igor Veresov igor.veresov at oracle.com
Fri Nov 29 17:07:23 PST 2013


Looks good.

igor

On Nov 29, 2013, at 6:21 AM, Rickard Bäckman <rickard.backman at oracle.com> wrote:

> Vladimir, thanks.
> 
> Still need one more Reviewer.
> 
> Thanks
> /R
> 
> On 11/28, Vladimir Kozlov wrote:
>> Good.
>> 
>> Thanks,
>> Vladimir
>> 
>> On 11/28/13 12:58 AM, Rickard Bäckman wrote:
>>> Updated again: http://cr.openjdk.java.net/~rbackman/8028997.2/
>>> 
>>> Thanks
>>> /R
>>> 
>>> On 11/25, Vladimir Kozlov wrote:
>>>> On 11/25/13 2:05 AM, Igor Ignatyev wrote:
>>>>> Rickard,
>>>>> 
>>>>> You should also add -XX:+IgnoreUnrecognizedVMOptions, because UseMathExactIntrinsics is a c2_only flag.
>>>> 
>>>> Yes.
>>>> 
>>>> Thanks,
>>>> Vladimir
>>>> 
>>>>> 
>>>>> On 11/25/2013 12:54 PM, Rickard Bäckman wrote:
>>>>>> Updated with flags for tests.
>>>>>> 
>>>>>> Webrev: http://cr.openjdk.java.net/~rbackman/8028997.1/
>>>>>> 
>>>>>> Thanks
>>>>>> /R
>>>>>> 
>>>>>> On 11/22, Vladimir Kozlov wrote:
>>>>>>> On 11/22/13 5:40 AM, Leonid Mesnik wrote:
>>>>>>>> Rickard
>>>>>>>> 
>>>>>>>> Does it make a sense to update corresponding tests by switching UseMathExactIntrinsics on explicitly?
>>>>>>> 
>>>>>>> Yes, it should be done in these changes.
>>>>>>> 
>>>>>>> Thanks,
>>>>>>> Vladimir
>>>>>>> 
>>>>>>>> 
>>>>>>>> Leonid
>>>>>>>> On 11/22/2013 05:31 PM, Rickard Bäckman wrote:
>>>>>>>>> Hi all,
>>>>>>>>> 
>>>>>>>>> can I have a couple of reviews for this small change?
>>>>>>>>> It basically sets the default value of UseMathExactIntrinsics to false
>>>>>>>>> and moves it to be an experimental vm option.
>>>>>>>>> 
>>>>>>>>> Webrev: http://cr.openjdk.java.net/~rbackman/8028997/
>>>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8028997
>>>>>>>>> 
>>>>>>>>> Thanks
>>>>>>>>> /R
>>>>>>>> 
>>>>>>>> 



More information about the hotspot-compiler-dev mailing list